netdev - r8169 driver compatibility with rtl8168 [need confirm]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 25 Feb 2008 23:03:58 +0100
From:	"Miroslav Kratochvil" <exa.exa@...il.com>
To:	netdev@...r.kernel.org
Subject: r8169 driver compatibility with rtl8168 [need confirm]

Hi,
Many users who have onboard Realtek 8168 network controllers in
combination with nVidia hardware (mostly nVidia graphic card and/or
nForce motherboard (MCP5x) ) experience still-not-very-explained
hangup triggered by heavy network usage which fills a tx buffer, and
(speculation) causes race condition on irq sharing, resulting in
absolute freeze (not oops/panic). On all affected machines I've seen
this fix solved the problem:

--- a/drivers/net/r8169.c   2008-02-25 22:53:01.000000000 +0100
+++ b/drivers/net/r8169.c   2008-02-25 22:54:32.000000000 +0100
@@ -86,8 +86,8 @@

 #define R8169_REGS_SIZE                256
 #define R8169_NAPI_WEIGHT      64
-#define NUM_TX_DESC    64      /* Number of Tx descriptor registers */
-#define NUM_RX_DESC    256     /* Number of Rx descriptor registers */
+#define NUM_TX_DESC    1024    /* Number of Tx descriptor registers */
+#define NUM_RX_DESC    1024    /* Number of Rx descriptor registers */
 #define RX_BUF_SIZE    1536    /* Rx Buffer size */
 #define R8169_TX_RING_BYTES    (NUM_TX_DESC * sizeof(struct TxDesc))
 #define R8169_RX_RING_BYTES    (NUM_RX_DESC * sizeof(struct RxDesc))

It's not really a fix, we do not address the real race cond. (or
whatever) problem, but it removes the hangup and causes no negative
side effects. I need someone else who can confirm that it works.

cheers,
[exa]

PS. There might already be some fixes, but I didn't manage to find them.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html