netdev - Re: [PATCH] Can not send icmp netunreach packet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080226224438.GA19937@ami.dom.local>
Date:	Tue, 26 Feb 2008 23:44:38 +0100
From:	Jarek Poplawski <jarkao2@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	lyw@...fujitsu.com, swhiteho@...hat.com, netdev@...r.kernel.org
Subject: Re: [PATCH] Can not send icmp netunreach packet

On Tue, Feb 26, 2008 at 01:30:30PM -0800, David Miller wrote:
> From: Jarek Poplawski <jarkao2@...il.com>
> Date: Tue, 26 Feb 2008 07:35:38 +0000
> 
> > On 26-02-2008 07:34, Li Yewang wrote:
> > > Hi All
> > > 
> > >    There is a bug about icmp netunreach.
> > >    If the kernel does not find a route for a packet, 
> > >    it must send a icmp netunreach packet to the source host, 
> > >    and  discard  the packet. But the  kernel  does not send 
> > >    a icmp netunreach packet because of the  fib_lookup
> > >    return value  of -ESRCH when a route  is not found. 
> > 
> > ...or because some function doesn't handle -ESRCH return from
> > fib_lookup? It seems changing this to -ESRCH was needed in some cases.
> > And you don't explain enough why it can't be handled later (like in
> > ipv4/route.c: ip_route_input_slow)?
> 
> This was changed to -ESRCH so that the proper statistics
> would be bumped.  So if we change it back, the statistics
> will be broken again.

Actually, I liked more this sophisticated explanation from the changelog:

http://git.kernel.org/?p=linux/kernel/git/davem/net-2.6.git;a=commitdiff;h=83886b6b636173b206f475929e58fac75c6f2446

BTW, it's really hard to find any place which could still behave as
described by Li. Wasn't it with some older kernel?

Jarek P.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html