netdev - RE: [PATCH] [resend]The kernel gets no IP from some DHCP servers, 2.6.24

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <83116F0A4FF67A4F97BA0B6E408C48E301C5CE6D@zuerich.BC-Int.NET>
Date:	Wed, 27 Feb 2008 18:25:10 +0100
From:	"Wappler Marcel" <Marcel.Wappler@...dgeco.net>
To:	"Stephen Hemminger" <shemminger@...tta.com>
Cc:	"Patrick McHardy" <kaber@...sh.net>,
	<linux-kernel@...r.kernel.org>, <netdev@...r.kernel.org>,
	<davem@...emloft.net>, <ebiederman@...i.com>
Subject: RE: [PATCH] [resend]The kernel gets no IP from some DHCP servers, 2.6.24

-----Original Message-----
>> In my opinion it is necessary to distinguish between INADDR_ANY and 
>> the ZERO address which ist requested to be in the DHCPDISCOVER packet.
>Just delete the lines and the address will be zero because of earlier memset().

>From my personal point of view it is important to document the requirement of the
two addresses to be 0.0.0.0 either through the code itself or through a comment
which states clear the side effect of memset'ting the structure. 

Both roads lead to Rome :-)

Marcel
--
Marcel Wappler
Bridgeco AG
CH-8600 Dübendorf
Switzerland
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html