netdev - Re: [PATCH] llc: dont trust payload size on test cmd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20080226.175140.187595682.davem@davemloft.net>
Date:	Tue, 26 Feb 2008 17:51:40 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	jwestfall@...realistic.net
Cc:	netdev@...r.kernel.org, acme@...stprotocols.net
Subject: Re: [PATCH] llc: dont trust payload size on test cmd

From: Jim Westfall <jwestfall@...realistic.net>
Date: Mon, 25 Feb 2008 08:14:39 -0800

> In testing its not safe to trust the payload length we are given in a
> received llc test command header.  Instead we should calculate this 
> ourselves or run the risk of an skb_over_panic() if the received length in 
> the header is > then the actual payload size.
> 
> Signed-off-by: Jim Westfall <jwestfall@...realistic.net>

I think we should, rather, use the value given to us in the
proto field, but validate it against the real packet length.

If it's found to be bogus, we should drop the packet.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html