netdev - Re: lockdep trace from rc2.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080226195157.46645a62@extreme>
Date:	Tue, 26 Feb 2008 19:51:57 -0800
From:	Stephen Hemminger <shemminger@...tta.com>
To:	David Miller <davem@...emloft.net>
Cc:	davej@...emonkey.org.uk, netdev@...r.kernel.org
Subject: Re: lockdep trace from rc2.

On Tue, 26 Feb 2008 18:13:54 -0800 (PST)
David Miller <davem@...emloft.net> wrote:

> From: Dave Jones <davej@...emonkey.org.uk>
> Date: Sun, 24 Feb 2008 21:22:37 -0500
> 
> > https://bugzilla.redhat.com/show_bug.cgi?id=431038 has some more info,
> > but the trace is below...
> > I'll get an rc3 kernel built and ask the user to retest, but in case this
> > isn't a known problem, I'm forwarding this here.
> 
> So basically, tulip's ->stop() calls tulip_down() which does a
> flush_scheduled_work().
> 
> Lockdep is saying that the RTNL mutex (which is held when we
> call the driver's ->stop() method) conflicts with that work
> queue lock that flush_scheduled_work() takes.
> 
> Maybe this has something to do with how linkwatch works, but
> I can't say that I've seen this before nor do I quite understand
> what lockdep doesn't exactly like here.
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

This has come up before in other drivers,
you can't call flush_scheduled_work under RTNL.
See:  http://article.gmane.org/gmane.linux.network/86941
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html