netdev - Re: [PATCH (resend)] Don't create tunnels with '%' in name.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20080226.235147.262588180.davem@davemloft.net>
Date:	Tue, 26 Feb 2008 23:51:47 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	xemul@...nvz.org
Cc:	netdev@...r.kernel.org, devel@...nvz.org
Subject: Re: [PATCH (resend)] Don't create tunnels with '%' in name.

From: Pavel Emelyanov <xemul@...nvz.org>
Date: Wed, 27 Feb 2008 10:44:33 +0300

> Four tunnel drivers (ip_gre, ipip, ip6_tunnel and sit) can
> receive a pre-defined name for a device from the userspace.
> Since these drivers call the register_netdevice() (rtnl_lock,
> is held), which does _not_ generate the device's name, this 
> name may contain a '%' character.
> 
> Not sure how bad is this to have a device with a '%' in its
> name, but all the other places either use the register_netdev(),
> which call the dev_alloc_name(), or explicitly call the 
> dev_alloc_name() before registering, i.e. do not allow for 
> such names.
> 
> This had to be prior to the commit 34cc7b, but I forgot to
> number the patches and this one got lost, sorry.
> 
> Signed-off-by: Pavel Emelyanov <xemul@...nvz.org>

Applied, thanks Pavel.

I've already sent a pull request to Linus an hour ago, so
this will get in next time around.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html