netdev - Re: [NET]: Messed multicast lists after dev_mc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 27 Feb 2008 13:46:14 +0100
From:	Johannes Berg <johannes@...solutions.net>
To:	Patrick McHardy <kaber@...sh.net>
Cc:	"David S. Miller" <davem@...emloft.net>,
	Linux Netdev List <netdev@...r.kernel.org>
Subject: Re: [NET]: Messed multicast lists after dev_mc_sync/unsync


> >> I don't think so, the users field was already initialized properly
> >> before. Is wireless using dev_unicast_sync or dev_mc_sync?
> > 
> > dev_mc_sync(), we sync all multicast addresses of all interfaces to the
> > master netdev to have a single consistent list. There used to be a
> > custom implementation of that but I replaced it.
> 
> 
> I can't see how this bug could be responsible, assuming da_synced
> intially contained a non-zero value it might forget to sync an
> address, but still try to delete it when unsyncing. __dev_addr_delete
> will simply do nothing in this case. But I guess the patch is still
> worth trying.

I don't know how it would cause it either, but seeing that I can't even
reliably reproduce the problem at least that seems like uninitialised
memory could cause it. I guess I'll see if I the problem ever turns up
again after this patch goes in...

johannes

Download attachment "signature.asc" of type "application/pgp-signature" (829 bytes)