netdev - Re: [PATCH 12/12 net-2.6.26] [ICMP6]: Consolidate fail path icmpv6_sk_init with icmpv6_sk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1204322741.7867.3.camel@iris.sw.ru>
Date:	Sat, 01 Mar 2008 01:05:41 +0300
From:	"Denis V. Lunev" <den@...nvz.org>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org, containers@...ts.osdl.org
Subject: Re: [PATCH 12/12 net-2.6.26] [ICMP6]: Consolidate fail path
	icmpv6_sk_init with icmpv6_sk_exit.

On Fri, 2008-02-29 at 11:23 -0800, David Miller wrote:
> From: "Denis V. Lunev" <den@...nvz.org>
> Date: Fri, 29 Feb 2008 16:40:58 +0300
> 
> > +static void __net_exit icmpv6_sk_exit(struct net *net)
> > +{
> 
> Since you call this from __new_init code, won't this
> create a section conflict when ipv6 is built statically
> into the kernel?

Dave, you are perfectly correct :) Though, I have made a similar mistake
in the IPv4 code. Pls consider the patch attached.

View attachment "diff-icmp-section.txt" of type "text/plain" (561 bytes)