netdev - Re: [PATCH] [NET 2.6.26]: Add per-connection option to set max TSO frame size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080229105319.GB4337@ff.dom.local>
Date:	Fri, 29 Feb 2008 10:53:20 +0000
From:	Jarek Poplawski <jarkao2@...il.com>
To:	PJ Waskiewicz <peter.p.waskiewicz.jr@...el.com>
Cc:	davem@...emloft.net, stephen.hemminger@...tta.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH] [NET 2.6.26]: Add per-connection option to set max TSO
	frame size

On Thu, Feb 28, 2008 at 10:31:50AM -0800, PJ Waskiewicz wrote:
...

Looks ...almost OK to me, but:

> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
> index a2f0032..b460fd3 100644
> --- a/include/linux/netdevice.h
> +++ b/include/linux/netdevice.h
> @@ -724,6 +724,10 @@ struct net_device
>  	/* rtnetlink link ops */
>  	const struct rtnl_link_ops *rtnl_link_ops;
>  
> +	/* for setting kernel sock attribute on TCP connection setup */
> +#define GSO_MAX_SIZE		65536
> +	u32			gso_max_size;
> +

Now probably unsigned int should "suffice" too.

>  	/* The TX queue control structures */
>  	unsigned int			egress_subqueue_count;
>  	struct net_device_subqueue	egress_subqueue[1];
> @@ -1475,6 +1479,11 @@ static inline int netif_needs_gso(struct net_device *dev, struct sk_buff *skb)
>  		unlikely(skb->ip_summed != CHECKSUM_PARTIAL));
>  }
>  
> +static inline void netif_set_gso_max_size(struct net_device *dev, u16 size)

u16?

> +{
> +       dev->gso_max_size = size;

^^^^^^^^^^ a tab needed here.
...
> diff --git a/include/net/sock.h b/include/net/sock.h
> index 8a7889b..1c52822 100644
> --- a/include/net/sock.h
> +++ b/include/net/sock.h
...
> @@ -236,6 +237,7 @@ struct sock {
>  	gfp_t			sk_allocation;
>  	int			sk_route_caps;
>  	int			sk_gso_type;
> +	__u32			sk_gso_max_size;

unsigned int? But, actually I wonder if sk_gso_type and sk_gso_max_size
can't be two shorts yet?

Regards,
Jarek P.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html