netdev - Re: [PATCH net-2.6.26 3/4] Use seq_open_private in appletalk and decnet.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080229141059.GK4306@ghostprotocols.net>
Date:	Fri, 29 Feb 2008 11:10:59 -0300
From:	Arnaldo Carvalho de Melo <acme@...hat.com>
To:	Pavel Emelyanov <xemul@...nvz.org>
Cc:	David Miller <davem@...emloft.net>,
	Linux Netdev List <netdev@...r.kernel.org>,
	Christine Caulfield <christine.caulfield@...glemail.com>
Subject: Re: [PATCH net-2.6.26 3/4] Use seq_open_private in appletalk and
	decnet.

Em Fri, Feb 29, 2008 at 04:48:24PM +0300, Pavel Emelyanov escreveu:
> These two also perform manual seq_open_private, so patch them both
> at once. But unlike ATM code, these already use the seq_release_private, 
> so I splitted this patch from the previous one.
> 
> Signed-off-by: Pavel Emelyanov <xemul@...nvz.org>
Acked-by: Arnaldo Carvalho de Melo <acme@...hat.com>
 
> ---
> 
> diff --git a/net/appletalk/aarp.c b/net/appletalk/aarp.c
> index 18058bb..61166f6 100644
> --- a/net/appletalk/aarp.c
> +++ b/net/appletalk/aarp.c
> @@ -1033,25 +1033,8 @@ static const struct seq_operations aarp_seq_ops = {
>  
>  static int aarp_seq_open(struct inode *inode, struct file *file)
>  {
> -	struct seq_file *seq;
> -	int rc = -ENOMEM;
> -	struct aarp_iter_state *s = kmalloc(sizeof(*s), GFP_KERNEL);
> -
> -	if (!s)
> -		goto out;
> -
> -	rc = seq_open(file, &aarp_seq_ops);
> -	if (rc)
> -		goto out_kfree;
> -
> -	seq	     = file->private_data;
> -	seq->private = s;
> -	memset(s, 0, sizeof(*s));
> -out:
> -	return rc;
> -out_kfree:
> -	kfree(s);
> -	goto out;
> +	return seq_open_private(file, &aarp_seq_ops,
> +			sizeof(struct aarp_iter_state));
>  }
>  
>  const struct file_operations atalk_seq_arp_fops = {
> 
> diff --git a/net/decnet/af_decnet.c b/net/decnet/af_decnet.c
> index acd48ee..23fd95a 100644
> --- a/net/decnet/af_decnet.c
> +++ b/net/decnet/af_decnet.c
> @@ -2320,25 +2320,8 @@ static const struct seq_operations dn_socket_seq_ops = {
>  
>  static int dn_socket_seq_open(struct inode *inode, struct file *file)
>  {
> -	struct seq_file *seq;
> -	int rc = -ENOMEM;
> -	struct dn_iter_state *s = kmalloc(sizeof(*s), GFP_KERNEL);
> -
> -	if (!s)
> -		goto out;
> -
> -	rc = seq_open(file, &dn_socket_seq_ops);
> -	if (rc)
> -		goto out_kfree;
> -
> -	seq		= file->private_data;
> -	seq->private	= s;
> -	memset(s, 0, sizeof(*s));
> -out:
> -	return rc;
> -out_kfree:
> -	kfree(s);
> -	goto out;
> +	return seq_open_private(file, &dn_socket_seq_ops,
> +			sizeof(struct dn_iter_state));
>  }
>  
>  static const struct file_operations dn_socket_seq_fops = {
> 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html