netdev - FW: [PATCH][I/OAT]: Remove duplicate assignation in dma_skb_copy_datagram

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <7F38996F7185A24AB9071ED4950AD8C1013A15FE@swsmsx413.ger.corp.intel.com>
Date:	Fri, 29 Feb 2008 14:30:00 -0000
From:	"Sosnowski, Maciej" <maciej.sosnowski@...el.com>
To:	<davem@...emloft.net>
Cc:	<netdev@...r.kernel.org>, <Brice.Goglin@...ia.fr>,
	"Nelson, Shannon" <shannon.nelson@...el.com>,
	"Williams, Dan J" <dan.j.williams@...el.com>
Subject: FW: [PATCH][I/OAT]: Remove duplicate assignation in dma_skb_copy_datagram_iovec

Dave,

This patch just removes redundant copy calculation. Please include it in
the tree.

Regards,
Maciej

[I/OAT]: Remove duplicate assignation in dma_skb_copy_datagram_iovec

No need to compute copy twice in the frags loop in
dma_skb_copy_datagram_iovec().

Signed-off-by: Brice Goglin <Brice.Goglin@...ia.fr>
Signed-off-by: Maciej Sosnowski <maciej.sosnowski@...el.com>
---
user_dma.c |    2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/core/user_dma.c b/net/core/user_dma.c
index 0ad1cd5..c77aff9 100644
--- a/net/core/user_dma.c
+++ b/net/core/user_dma.c
@@ -75,7 +75,7 @@ int dma_skb_copy_datagram_iovec(struct dma_chan *chan,

               end = start + skb_shinfo(skb)->frags[i].size;
               copy = end - offset;
-               if ((copy = end - offset) > 0) {
+               if (copy > 0) {
                       skb_frag_t *frag = &skb_shinfo(skb)->frags[i];
                       struct page *page = frag->page;

Acked-by: Shannon Nelson <shannon.nelson@...el.com>
---------------------------------------------------------------------
Intel Technology Poland sp. z o.o.
z siedziba w Gdansku
ul. Slowackiego 173
80-298 Gdansk

Sad Rejonowy Gdansk Polnoc w Gdansku, 
VII Wydzial Gospodarczy Krajowego Rejestru Sadowego, 
numer KRS 101882

NIP 957-07-52-316
Kapital zakladowy 200.000 zl

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html