netdev - Re: [PATCH (resend)][EBTABLES]: Fix alignment checks in ebt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0802291639390.24056@fbirervta.pbzchgretzou.qr>
Date:	Fri, 29 Feb 2008 16:40:24 +0100 (CET)
From:	Jan Engelhardt <jengelh@...putergmbh.de>
To:	Patrick McHardy <kaber@...sh.net>
cc:	Pavel Emelyanov <xemul@...nvz.org>,
	David Miller <davem@...emloft.net>,
	Linux Netdev List <netdev@...r.kernel.org>,
	Bart De Schuymer <bdschuym@...dora.be>,
	Netfilter Development Mailinglist 
	<netfilter-devel@...r.kernel.org>
Subject: Re: [PATCH (resend)][EBTABLES]: Fix alignment checks in ebt_among.ko
 module.


On Feb 29 2008 13:48, Patrick McHardy wrote:
> Pavel Emelyanov wrote:
>> I've sent this patch some days ago to Bart, but with no answer...
>> 
>> When trying to do
>> 
>>  # ebtables -A FORWARD --among-src 0:12:34:56:78:9a=192.168.0.10 -j ACCEPT
>> 
>> on x86_64 box the ebt_among->check() callback warns me that
>> 
>>  ebtables: among: wrong size: 1060 against expected 1056, rounded to 1056
>> [...]
>
> It seems the kernel is correct and userspace is doing it
> wrong, so I think userspace should be fixed instead.
> The problem with your patch is that is causes misalignment
> for following structures that contain u64 members.

ebt_among is a true mess! It hinders my efforts to port ebtables
to xtables, but I could of course use a hack and will likely
do just that.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html