netdev - Re: [PATCH] [ATM]: Add error handling for proc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080229.103803.151963676.davem@davemloft.net>
Date:	Fri, 29 Feb 2008 10:38:03 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	wangchen@...fujitsu.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] [ATM]: Add error handling for proc_create fail

From: Wang Chen <wangchen@...fujitsu.com>
Date: Fri, 29 Feb 2008 15:43:24 +0800

> @@ -963,6 +963,10 @@ static int __init atm_clip_init(void)
>  		struct proc_dir_entry *p;
>  
>  		p = proc_create("arp", S_IRUGO, atm_proc_root, &arp_seq_fops);
> +		if (!p) {
> +			printk(KERN_ERR "Unable to initialize /proc/atm/arp\n");
> +			return -ENOMEM;
> +		}
>  	}
>  #endif
>  

This is not sufficient.  If this fails you need to unregister
the ioctl and all of the other things that get registered
before this procfs registry runs.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html