netdev - Patch: [NET]: Remove CONFIG_PROC_FS depency for pcounter inuse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <47C8E777.5050804@hartkopp.net>
Date:	Sat, 01 Mar 2008 06:19:51 +0100
From:	Oliver Hartkopp <oliver@...tkopp.net>
To:	Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
	Eric Dumazet <dada1@...mosbay.com>,
	David Miller <davem@...emloft.net>
CC:	netdev@...r.kernel.org
Subject: Patch: [NET]: Remove CONFIG_PROC_FS depency for pcounter inuse

Hi all,

attached you'll find a patch that fixes the depency that has been 
introduced in commit 65f7651788e18fadb2fbb7276af935d7871e1803 ([NET]: 
prot_inuse cleanups and optimizations).

As the inuse counters are only used by internet protocols right now, 
using CONFIG_INET would have been more obvious to recognize this illegal 
optimization here. Going a bit deeper into this problem we can see, that 
the pcounters are ONLY used for the internet protocols BUT initialized 
for ALL protocols in proto_[un|]register() in net/core/sock.c.

This forces all network protocols to initialize the pcounters and 
therefore request dynamic percpu memory even when it is not used at all.

I would suggest to

1. move the ..._inuse_[init|free]() stuff from sock.c to af_inet[|6].c 
and his friends

OR

2. add new parameters to proto_[un|]register() like 'alloc_inuse' and 
'free_inuse'

My favourite sollution would be the second one but before creating a 
patch for one of these suggestions, i wanted to ask for your opinion or 
if there is any 'even nicer' idea from your side.

Regards,
Oliver

View attachment "remove_config_proc_fs_depency_for_pcounter_inuse.patch" of type "text/x-patch" (645 bytes)