netdev - Re: RFC [PATCH 1/3] TCP_DEFER_ACCEPT updates: defer timeouts conflict with max

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 01 Mar 2008 11:41:50 +0100
From:	Eric Dumazet <dada1@...mosbay.com>
To:	Patrick McManus <mcmanus@...ksong.com>
CC:	Netdev@...r.kernel.org
Subject: Re: RFC [PATCH 1/3] TCP_DEFER_ACCEPT updates: defer timeouts conflict
 with max_thresh

Patrick McManus a écrit :
> Signed-off-by: Patrick McManus <mcmanus@...ksong.com>
> 
>     timeout associated with SO_DEFER_ACCEPT wasn't being honored if it was
>     less than the timeout allowed by the maximum syn-recv queue size
>     algorithm. Fix by using the SO_DEFER_ACCEPT value if the ack has
>     arrived.
> 
> diff --git a/net/ipv4/inet_connection_sock.c b/net/ipv4/inet_connection_sock.c
> index b189278..03cc323 100644
> --- a/net/ipv4/inet_connection_sock.c
> +++ b/net/ipv4/inet_connection_sock.c
> @@ -461,8 +461,7 @@ void inet_csk_reqsk_queue_prune(struct sock *parent,
>                 reqp=&lopt->syn_table[i];
>                 while ((req = *reqp) != NULL) {
>                         if (time_after_eq(now, req->expires)) {
> -                               if ((req->retrans < thresh ||
> -                                    (inet_rsk(req)->acked && req->retrans < max_retries))
> +                               if ((req->retrans < (inet_rsk(req)->acked ? max_retries : thresh))
>                                     && !req->rsk_ops->rtx_syn_ack(parent, req, NULL)) {
>                                         unsigned long timeo;
> 
> 
> 

Acked-by: Eric Dumazet <dada1@...mosbay.com>

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html