netdev - Re: [PATCH] New driver "sfc" for Solarstorm SFC4000 controller (try #7)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 03 Mar 2008 13:29:41 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	bhutchings@...arflare.com
Cc:	shemminger@...tta.com, dcbw@...hat.com, netdev@...r.kernel.org
Subject: Re: [PATCH] New driver "sfc" for Solarstorm SFC4000 controller
 (try #7)

From: Ben Hutchings <bhutchings@...arflare.com>
Date: Mon, 3 Mar 2008 21:17:44 +0000

> It's not a simple device.  There are callbacks into MAC-, PHY- and
> board-specific code because this code supports several of each.  I
> spent some weeks ruthlessly paring away unnecessary abstraction and
> cruft, and I don't believe there is a significant amount left.

That is your opinion.

We have drivers that handle 30 or so variants of a particular
ethernet chipset and they are not nearly so huge as this
driver, and some of those cases don't have firmware either.

The driver needs to be reviewed on at least some level, but nobody is
going to walk through a 700K driver.  And I do mean nobody.

You have to find a way to trim this driver down and make it
more reviewable.

If I can write a full 10Gbit driver in ~11,000 lines of code
(~200,000 bytes), so can anyone else.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html