netdev - RE: [PATCH 2/7 net-2.6.26] [TIPC]: Add argument validation for shutdown()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AF1602CB2550CE4381C0C75118A7856B0252E545@ala-mail02.corp.ad.wrs.com>
Date:	Tue, 4 Mar 2008 13:58:05 -0800
From:	"Stephens, Allan" <allan.stephens@...driver.com>
To:	"David Miller" <davem@...emloft.net>
Cc:	<netdev@...r.kernel.org>
Subject: RE: [PATCH 2/7 net-2.6.26] [TIPC]: Add argument validation for shutdown()

Arrgh!  You're right, Dave.  I was concentrating on fixing the problems
with my email client and let things get out of sync.  I'll fix 'em up
and resubmit.

-- Al 

-----Original Message-----
From: David Miller [mailto:davem@...emloft.net] 
Sent: Tuesday, March 04, 2008 4:44 PM
To: Stephens, Allan
Cc: netdev@...r.kernel.org
Subject: Re: [PATCH 2/7 net-2.6.26] [TIPC]: Add argument validation for
shutdown()

From: Allan Stephens <allan.stephens@...driver.com>
Date: Tue,  4 Mar 2008 16:20:14 -0500

> This patch validates that the "how" argument to shutdown() is 
> SHUT_RDWR, since this is the only form that TIPC supports.
> 
> Signed-off-by: Allan Stephens <allan.stephens@...driver.com>

You really didn't generate this patch against the current
net-2.6.26 tree:

davem@...set:~/src/GIT/net-2.6.26$ pcheck diff
+ git apply --check --whitespace=error-all diff
error: patch failed: net/tipc/socket.c:1432
error: net/tipc/socket.c: patch does not apply

The line numbers are all off.  Likely you generated this against a
net-2.6.26 tree from before the semaphore-->mutex TIPC changeset went
in, throwing all the line numbers off.

I'm not looking at the rest of your patches, sorry.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html