netdev - Re: [IPV4]: Add an 'rtable' field in struct sk_buff to alias 'dst' field and avoid casts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080303.234649.109971767.davem@davemloft.net>
Date:	Mon, 03 Mar 2008 23:46:49 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	dada1@...mosbay.com
Cc:	netdev@...r.kernel.org
Subject: Re: [IPV4]: Add an 'rtable' field in struct sk_buff to alias 'dst'
 field and avoid casts

From: Eric Dumazet <dada1@...mosbay.com>
Date: Tue, 04 Mar 2008 08:36:43 +0100

> Yes, I had this idea, but felt that it was better in this case to have a 
> dst_hold() that refers to the above affectation.
> 
> skb->dst = &__fake_rtable.u.dst;
> dst_hold(skb->dst);
> 
> instead of
> 
> skb->rtable = &__fake_rtable;
> dst_hold(skb->dst);
> 
> Do you prefer the later ?

Wouldn't it be pleasant if you could pass
&__fake_rtable to dst_hold() directly?

Can't we do that by making it's arg an anonymous union like the thing
you're doing here?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html