netdev - Re: [PATCH] Remove usage of C++ keyword 'class' on htb.h header.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 4 Mar 2008 12:53:32 -0800
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	Rui Tiago Cação Matos <rmatos@...it.pt>
Cc:	tgraf@...g.ch, netdev@...r.kernel.org
Subject: Re: [PATCH] Remove usage of C++ keyword 'class' on htb.h header.

On Tue,  4 Mar 2008 18:31:16 +0000 Rui Tiago Cação Matos wrote:

> Signed-off-by: Rui Tiago Cação Matos <rmatos@...it.pt>
> ---
>  include/netlink/route/sch/htb.h |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/include/netlink/route/sch/htb.h b/include/netlink/route/sch/htb.h
> index 5d4d681..d44f039 100644
> --- a/include/netlink/route/sch/htb.h
> +++ b/include/netlink/route/sch/htb.h
> @@ -30,9 +30,9 @@ extern void rtnl_htb_set_rate(struct rtnl_class *, uint32_t);
>  extern void rtnl_htb_set_ceil(struct rtnl_class *, uint32_t);
>  extern void rtnl_htb_set_rbuffer(struct rtnl_class *, uint32_t);
>  extern void rtnl_htb_set_cbuffer(struct rtnl_class *, uint32_t);
> -extern void rtnl_htb_set_quantum(struct rtnl_class *class, uint32_t quantum);
> -extern void rtnl_htb_set_overhead(struct rtnl_class *class, uint8_t overhead);
> -extern void rtnl_htb_set_mpu(struct rtnl_class *class, uint8_t mpu);
> +extern void rtnl_htb_set_quantum(struct rtnl_class *, uint32_t quantum);
> +extern void rtnl_htb_set_overhead(struct rtnl_class *, uint8_t overhead);
> +extern void rtnl_htb_set_mpu(struct rtnl_class *, uint8_t mpu);
>  
>  #ifdef __cplusplus
>  }


We generally prefer to see function parameter names present in prototypes.

What about the other 30 or so C++ keywords that the kernel uses?
Do you have a metric ton of more patches?

---
~Randy
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html