netdev - Re: [PATCH] net/enc28j60: low power mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <200803051531.16334.david-b@pacbell.net>
Date:	Wed, 5 Mar 2008 15:31:16 -0800
From:	David Brownell <david-b@...bell.net>
To:	Jeff Garzik <jgarzik@...ox.com>
Cc:	Claudio Lanconelli <lanconelli.claudio@...ar.com>,
	netdev@...r.kernel.org
Subject: Re: [PATCH] net/enc28j60: low power mode

On Wednesday 05 March 2008, Jeff Garzik wrote:
> Claudio Lanconelli wrote:
> > Keep enc28j60 chips in low-power mode when they're not in use.
> > At typically 120 mA, these chips run hot even when idle; this
> > low power mode cuts that power usage by a factor of around 100.
> > 
> > This version provides a generic routine to poll a register until
> > its masked value equals some value ...
> 
> It's a bit silly to create a variable just to store the result of 
> msecs_to_jiffies(constant)

Sillier to replace a compile-time constant with a runtime function
call!  The msecs_to_jiffies() implementation doesn't optimize the
case of a constant parameter -- there's no inlined version.




--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html