netdev - Re: [patch (for 2.6.25?) 1/2] The kernel gets no IP from some DHCP servers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080304162342.65d6340c@extreme>
Date:	Tue, 4 Mar 2008 16:23:42 -0800
From:	Stephen Hemminger <shemminger@...ux-foundation.org>
To:	akpm@...ux-foundation.org
Cc:	davem@...emloft.net, netdev@...r.kernel.org,
	akpm@...ux-foundation.org, Marcel.Wappler@...dgeco.net,
	kaber@...sh.net
Subject: Re: [patch (for 2.6.25?) 1/2] The kernel gets no IP from some DHCP
 servers

On Tue, 04 Mar 2008 14:56:48 -0800
akpm@...ux-foundation.org wrote:

> From: "Wappler Marcel" <Marcel.Wappler@...dgeco.net>
> 
> This patch fixes a DHCP issue of the kernel: some DHCP servers (i.e.  in the
> Linksys WRT54Gv5) are very strict about the contents of the DHCPDISCOVER
> packet they receive from clients.
> 
> Table 5 in RFC2131 page 36 requests the fields 'ciaddr' and 'siaddr' MUST be
> set to '0'.  These DHCP servers ignore Linux kernel's DHCP discovery packets
> with these two fields set to '255.255.255.255' (in contrast to popular DHCP
> clients, such as 'dhclient' or 'udhcpc').  This leads to a not booting system.
> 
> I tested this on a ARM embedded device mounting rootfs over NFS obtaining its
> IP from a Linksys WRT54Gv5 Router running VxWorks and a PC based Server
> running a Linux.  Changing the two fields to '0.0.0.0' worked.
> 
> Cc: Stephen Hemminger <shemminger@...l.org>
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: Patrick McHardy <kaber@...sh.net>
> Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>
> ---

Same patch without the noise comment and extra code.

--- a/net/ipv4/ipconfig.c	2008-03-04 16:20:10.000000000 -0800
+++ b/net/ipv4/ipconfig.c	2008-03-04 16:22:49.000000000 -0800
@@ -753,9 +753,9 @@ static void __init ic_bootp_send_if(stru
 		printk("Unknown ARP type 0x%04x for device %s\n", dev->type, dev->name);
 		b->htype = dev->type; /* can cause undefined behavior */
 	}
+
+	/* server_ip and your_ip address are both already zero per RFC2131 */
 	b->hlen = dev->addr_len;
-	b->your_ip = NONE;
-	b->server_ip = NONE;
 	memcpy(b->hw_addr, dev->dev_addr, dev->addr_len);
 	b->secs = htons(jiffies_diff / HZ);
 	b->xid = d->xid;
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html