netdev - Re: [patch 0/9][NETNS][IPV6] make addrconf and icmp per namespace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080305.111308.05959072.davem@davemloft.net>
Date:	Wed, 05 Mar 2008 11:13:08 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	dlezcano@...ibm.com
Cc:	netdev@...r.kernel.org, benjamin.thery@...l.net
Subject: Re: [patch 0/9][NETNS][IPV6] make addrconf and icmp per namespace

From: Daniel Lezcano <dlezcano@...ibm.com>
Date: Wed, 05 Mar 2008 18:56:49 +0100

> The following patchset makes the different part of ipv6 to take
> into account the namespaces. On top of that, addrconf and icmp
> are now aware how to use the namespaces too. So we can move an
> interface inside the namespace and set ip up to have an ipv6
> address autoconfigured and be able to ping it.
> 
> ndisc will come very soon ... :)

Applied and pushed out to net-2.6.26, thanks.

Can you quickly resolve this turd which got added by
these changes to net/ipv6/addrconf.c?

static void addrconf_net_exit(struct net *net)
{
	struct net_device *dev;

	/*
	 * Remove loopback references from default routing entries
	 */
/* 	in6_dev_put(net->ipv6.ip6_null_entry->rt6i_idev); */
/* #ifdef CONFIG_IPV6_MULTIPLE_TABLES */
/* 	in6_dev_put(net->ipv6.ip6_prohibit_entry->rt6i_idev); */
/* 	in6_dev_put(net->ipv6.ip6_blk_hole_entry->rt6i_idev); */
/* #endif */

Either turn the code on or remove it.

The upstream tree isn't a place to take "notes" using commented out
code to remind you later about something.

Thanks.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html