netdev - Re: [PATCH]kernel crashes when using aes-xcbc-mac with IPsec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080306112946.GA7083@gondor.apana.org.au>
Date:	Thu, 6 Mar 2008 19:29:46 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Joy Latten <latten@...tin.ibm.com>
Cc:	linux-crypto@...r.kernel, davem@...emloft.net,
	netdev@...r.kernel.org
Subject: Re: [PATCH]kernel crashes when using aes-xcbc-mac with IPsec

On Wed, Mar 05, 2008 at 08:51:20AM -0600, Joy Latten wrote:
> When using aes-xcbc-mac for authentication in IPsec, 
> the kernel crashes. It seems this algorithm doesn't 
> account for the space IPsec may make in scatterlist for authtag.
> Thus when crypto_xcbc_digest_update2() gets called,
> nbytes may be less than sg[i].length. 
> Since nbytes is an unsigned number, it wraps
> at the end of the loop allowing us to go back 
> into loop and causing crash in memcpy.
> 
> I used update function in digest.c to model this fix.
> Please let me know if it looks ok.
> 
> regards,
> Joy 
> 
> Signed-off-by: Joy Latten <latten@...tin.ibm.com>

Good catch! Patch applied, thanks Joy.
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html