netdev - Re: [IPV4]: Add an 'rtable' field in struct sk_buff to alias 'dst' field and avoid casts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <47D077D5.50306@cosmosbay.com>
Date:	Fri, 07 Mar 2008 00:01:41 +0100
From:	Eric Dumazet <dada1@...mosbay.com>
To:	David Miller <davem@...emloft.net>
CC:	netdev@...r.kernel.org
Subject: Re: [IPV4]: Add an 'rtable' field in struct sk_buff to alias 'dst'
 field and avoid casts

David Miller a écrit :
> From: Eric Dumazet <dada1@...mosbay.com>
> Date: Thu, 06 Mar 2008 00:30:02 +0100
> 
>> [IPV4]: Add an 'rtable' field in struct sk_buff to alias 'dst' field and avoid 
>> casts
>>
>> (Anonymous) unions can help us to avoid ugly casts.
>>
>> A common cast it the (struct rtable *)skb->dst one.
>>
>> Defining an union like  :
>> union {
>>      struct dst_entry *dst;
>>      struct rtable *rtable;
>> };
>> permits to use dkb->rtable in place.
>>
>> Signed-off-by: Eric Dumazet <dada1@...mosbay.com>
>>
> 
> Applied with some minor changelog tidy and typo fixups.
> 
> Please make your changelog entry header lines smaller in
> the future.  People scan them in shortlog output and it's
> less readable if it's wider than standard terminal widths.

Thanks David, I'll try to shorten headers :)

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html