lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Fri, 07 Mar 2008 16:00:10 -0800
From:	"Kok, Auke" <>
Subject: Re: [patch 16/17] drivers/net/8390.c: replace init_module&cleanup_module
 with module_init&module_exit wrote:
> From: Jon Schindler <>
> Replace init_module and cleanup_module with static functions and
> module_init/module_exit.
> Signed-off-by: Jon Schindler <>
> Cc: Alan Cox <>
> Signed-off-by: Andrew Morton <>

something went wrong here as this patch already appears to be in jeff's upstream
tree as commit 8724c2de65fe527f5b7aa662fcb8573fb8cd02f2, but breaks compile.


  CC [M]  drivers/net/8390.o
drivers/net/8390.c: In function '__inittest':
drivers/net/8390.c:60: error: 'ns8390_init_module' undeclared (first use in this
drivers/net/8390.c:60: error: (Each undeclared identifier is reported only once
drivers/net/8390.c:60: error: for each function it appears in.)
make[2]: *** [drivers/net/8390.o] Error 1
make[1]: *** [drivers/net] Error 2
make: *** [drivers] Error 2

reverting the patch fixes the issue, but better would be to fix.

Signed-off-by: Auke Kok <>
Cc: Jon Schindler <>
Cc: Alan Cox <>
Cc: Andrew Morton <>

diff --git a/drivers/net/8390.c b/drivers/net/8390.c
index 0ed41a3..a499e86 100644
--- a/drivers/net/8390.c
+++ b/drivers/net/8390.c
@@ -57,7 +57,7 @@ static void __exit ns8390_module_exit(void)

 #endif /* MODULE */
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to
More majordomo info at

Powered by blists - more mailing lists