netdev - Re: [PATCH 6/9] fs_enet: Be an of_platform device when CONFIG_PPC_CPM_NEW

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200803101205.16158.laurentp@cse-semaphore.com>
Date:	Mon, 10 Mar 2008 12:05:08 +0100
From:	Laurent Pinchart <laurentp@...-semaphore.com>
To:	Sergej Stepanov <Sergej.Stepanov@....de>
Cc:	Scott Wood <scottwood@...escale.com>, linuxppc-dev@...abs.org,
	jgarzik@...ox.com, netdev@...r.kernel.org
Subject: Re: [PATCH 6/9] fs_enet: Be an of_platform device when CONFIG_PPC_CPM_NEW_BINDING is set.

On Monday 10 March 2008 08:50, Sergej Stepanov wrote:
> > Acked-by: Scott Wood <scottwood@...escale.com>, if I haven't already.
> >
> > -Scott
>
> I thought, you did it.
> Thank you.

Your documentation patch states that

"The first reg resource is the I/O port register block on which MDIO
resides.  The second reg resource is the I/O port register block on
which MDC resides.  If there is only one reg resource, it is used for
both MDIO and MDC."

If I'm not mistaken the code uses the first reg resource for MDC and the 
second reg resource for MDIO. Which one should be fixed, the doc or the 
code ?

Best regards,

-- 
Laurent Pinchart
CSE Semaphore Belgium

Chaussée de Bruxelles, 732A
B-1410 Waterloo
Belgium

T +32 (2) 387 42 59
F +32 (2) 387 42 75

Content of type "application/pgp-signature" skipped