lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 17 Mar 2008 23:10:52 +1100 From: Rusty Russell <rusty@...tcorp.com.au> To: Christian Borntraeger <borntraeger@...ibm.com> Cc: netdev@...r.kernel.org, virtualization@...ts.linux-foundation.org Subject: Re: [PATCH] virtio_net/virtio_ring: fix race in enable_cb On Monday 17 March 2008 17:30:44 Christian Borntraeger wrote: > > Are you seeing the "Unlikely: restart svq failed" message in the logs? > > If not, I don't think it can be this race. > > No, I dont see the message, but this message only happens for guest->host > traffic in the xmit function. Interesting you don't see this. Or is it just on that load that you don't see it? > I was fixing the poll function - which has no > printk. > I added the disable_cb in the xmit function only to adopt to changed > enable_cb semantics. > > I double checked my theory with a printk in enable_cb. The more_used check > was true several times for the receiving virtqueue. Excellent, thanks. I applied your patch, and have asked Linus to pull that and my other qeued virtio fixes. Cheers, Rusty. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists