netdev - Re: [PATCH 0/7][MV643XX_ETH] various cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080318164045.GB28917@xi.wantstofly.org>
Date:	Tue, 18 Mar 2008 17:40:45 +0100
From:	Lennert Buytenhek <buytenh@...tstofly.org>
To:	Dale Farnsworth <dale@...nsworth.org>
Cc:	netdev@...r.kernel.org, Nicolas Pitre <nico@...vell.com>,
	Tzachi Perelstein <tzachi@...vell.com>,
	Saeed Bishara <saeed@...vell.com>
Subject: Re: [PATCH 0/7][MV643XX_ETH] various cleanups

On Tue, Mar 18, 2008 at 09:14:06AM -0700, Dale Farnsworth wrote:

> > This patch series performs various cleanups of mv643xx_eth, and moves
> > it into the direction of being able to be instantiated multiple times
> > -- which is currently not possible due to the driver using static
> > variables, identifying ports by their port index within the single
> > supported instance[*] instead of a pointer to a describing structure,
> > and such.
> > 
> > The goal of multiple instantiation isn't achieved yet by this patch
> > set, since it requires some changes in how mv643xx_eth platform
> > devices are instantiated which in turn requires some changes in
> > arch/{ppc,powerpc} which haven't been fully sorted out and agreed
> > upon yet -- but this patch set is a step in the general direction,
> > and the maintainer has informally ACKed these patches previously
> > (in private mail), so I'm seeking wider feedback on them now.
> 
> Hi Lennert,

Hi Dale,


> I'm happy with the end result, but the current patch series will
> not build after patches 1-3 are applied.  Please reorder your
> code changes so the result will be git-bisectable.

Urgh.  I could have sworn that I checked that.  Anyway, sorry.

Fixed patch series here:
	http://www.wantstofly.org/~buytenh/mv643xx_eth/

Does that look better?


thanks,
Lennert
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html