lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 20 Mar 2008 13:53:36 +0800 From: Wei Yongjun <yjwei@...fujitsu.com> To: lksctp-developers@...ts.sourceforge.net CC: Vlad Yasevich <vladislav.yasevich@...com>, netdev@...r.kernel.org, David Miller <davem@...emloft.net> Subject: [PATCH] SCTP: Fix sctp_auth_asoc_get_hmac() to avoid kernel panic If association is setup with HMAC-ALGO parameter in which there is no HMAC algorithm supported by the endpoint, send a chunk with AUTH will cause kernel panic. This is because when send chunk with AUTH, sctp_auth_asoc_get_hmac() will be used to get the hmac. In this function, if the HMAC-ALGO is empty, it return NULL. If is not empty, it will find a valid hmac for using. But if all of the HMAC-ALGOs is not supported by endpoint, it will return a bogus pointer, not expected NULL pointer. This patch fix this problem. Signed-off-by: Wei Yongjun <yjwei@...fujitsu.com> --- a/net/sctp/auth.c 2008-02-11 17:14:05.000000000 -0500 +++ b/net/sctp/auth.c 2008-02-14 02:01:18.000000000 -0500 @@ -549,13 +549,10 @@ struct sctp_hmac *sctp_auth_asoc_get_hma if (!sctp_hmac_list[id].hmac_name) continue; - break; + return &sctp_hmac_list[id]; } - if (id == 0) - return NULL; - - return &sctp_hmac_list[id]; + return NULL; } static int __sctp_auth_find_hmacid(__be16 *hmacs, int n_elts, __be16 hmac_id) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists