netdev - Re: [PATCH] [RFC] [IPv6] spelling fix in /proc: /proc/sys/net/ipv6/conf/default/temp_prefered

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080320090011.GK6935@ens-lyon.fr>
Date:	Thu, 20 Mar 2008 10:00:11 +0100
From:	Benoit Boissinot <benoit.boissinot@...-lyon.org>
To:	David Miller <davem@...emloft.net>
Cc:	joe@...ches.com, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org, pekkas@...core.fi, yoshfuji@...ux-ipv6.org
Subject: Re: [PATCH] [RFC] [IPv6] spelling fix in /proc:
	/proc/sys/net/ipv6/conf/default/temp_prefered_lft

On Wed, Mar 19, 2008 at 06:56:49PM -0700, David Miller wrote:
> From: Joe Perches <joe@...ches.com>
> Date: Wed, 19 Mar 2008 18:25:19 -0700
> 
> > On Wed, 2008-03-19 at 13:52 -0700, David Miller wrote:
> > > From: Benoit Boissinot <benoit.boissinot@...-lyon.org>
> > > Date: Wed, 19 Mar 2008 21:42:27 +0100
> > > > Here is a patch to fix all the spelling error (prefered -> preferred)
> > > I think this doesn't add any value.
> > > If the procfs file name has to remain the same, which it does,
> > > changing variable and macro names to be different will only
> > > cause merge conflicts and pain yet have no redeeming value.
> > 
> > I disagree.  Proper spelling has value.
> 
> Only if it matches the spelling of thing it is implementing!
> 
> Making the object being implemented and the variables used to do so
> disagree in name will only create other kinds of confusion.

The file already have both occurences, there are function names and
variable with "preferred", sometimes mixed in the same line.

If it can help, the last time a line which uses prefered_lft was
changed, it was more than a year ago (1ab1457c42bc078e5a9becd82a7f9f940b55c53a)
for a whitespace cleanup.
Most of the occurences haven't been touched since the conversion to git.

regards,

Benoit

PS: I don't really care, it's just that I was touching the lifetime code
and tought that maybe I should try to change the whole file before
submitting my code.
-- 
:wq
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html