netdev - Re: [PATCH/RFC] introduce ARCH_CAN_UNALIGNED

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1206025097.16475.139.camel@johannes.berg>
Date:	Thu, 20 Mar 2008 15:58:17 +0100
From:	Johannes Berg <johannes@...solutions.net>
To:	Will Newton <will.newton@...il.com>
Cc:	Daniel Drake <dsd@...too.org>,
	Linux Kernel list <linux-kernel@...r.kernel.org>,
	linux-wireless <linux-wireless@...r.kernel.org>,
	netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH/RFC] introduce ARCH_CAN_UNALIGNED_ACCESS Kconfig symbol


On Thu, 2008-03-20 at 14:39 +0000, Will Newton wrote:
> On Thu, Mar 20, 2008 at 2:34 PM, Johannes Berg
> <johannes@...solutions.net> wrote:
> 
> >  +For some ethernet hardware that cannot DMA to unaligned addresses like
> >  +4*n+2 or non-ethernet hardware, this can be a problem, and it is then
> >  +required to copy the incoming frame into an aligned buffer. Because this is
> >  +unnecessary on architectures that can do unaligned accesses, the code can be
> >  +made depend on CONFIG_ARCH_CAN_UNALIGNED_ACCESS like so:
> >  +
> >  +#ifdef CONFIG_ARCH_CAN_UNALIGNED_ACCESS
> >  +       skb = copy skb
> >  +#else
> >  +       skb = original skb
> >  +#endif
> 
> Is this logic reversed?

Euh, indeed, thanks. Will repost after having more comments.

johannes

Download attachment "signature.asc" of type "application/pgp-signature" (829 bytes)