netdev - Re: [PATCH/RFC v3] introduce ARCH_CAN_UNALIGNED

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1206040323.16475.155.camel@johannes.berg>
Date:	Thu, 20 Mar 2008 20:12:03 +0100
From:	Johannes Berg <johannes@...solutions.net>
To:	Harvey Harrison <harvey.harrison@...il.com>
Cc:	Sam Ravnborg <sam@...nborg.org>, Daniel Drake <dsd@...too.org>,
	Linux Kernel list <linux-kernel@...r.kernel.org>,
	linux-wireless <linux-wireless@...r.kernel.org>,
	netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH/RFC v3] introduce ARCH_CAN_UNALIGNED_ACCESS Kconfig
	symbol

> > +#ifdef CONFIG_HAVE_UNALIGNED_ACCESS_SUPPORT
> > +	skb = original skb
> > +#else
> > +	skb = copy skb
> > +#endif
> > +
> 
> Couldn't this just be made an inline in a networking header somewhere,
> instead of ifdefs in the code?

That was just an example, you might want to do other things too. If it
turns out that a similar code pattern will be used all over the place we
can then consolidate that.

johannes

Download attachment "signature.asc" of type "application/pgp-signature" (829 bytes)