netdev - Question regarding netif_tx_disable and netif_stop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <a967d7d00803211509g3154f996jc7f0337fd56e0c1@mail.gmail.com>
Date:	Fri, 21 Mar 2008 15:09:32 -0700
From:	"Keyur Chudgar" <kchudgar.linux@...il.com>
To:	netdev@...r.kernel.org
Subject: Question regarding netif_tx_disable and netif_stop_queue

Hi,

I am writing a device driver for new emac hardware. I have a question regarding
netif_tx_disable and netif_stop_queue.

If the Emac hardware's queue is full and I need to assist the kernel with
stopping the packet scheduling from kernel, which function should
I use, if I am invoking it from outside of hard_start_xmit method?
Probably it will
be from the interrupt context or polling routine. From the review, I
understand that
I should use netif_tx_disable(struct net_device *dev); and not use
netif_stop_queue
(this function is generally used from within hard_start_xmit). I think
netif_tx_disable
is more suitable for SMP environment also, as it takes care for
hard_start_xmit method
is not running on another CPU. But I just would like to make sure about it.

Thanks,
- Keyur
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html