netdev - Re: [git patches] net driver updates for .26

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080322.183522.124237568.davem@davemloft.net>
Date:	Sat, 22 Mar 2008 18:35:22 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	jeff@...zik.org
Cc:	netdev@...r.kernel.org
Subject: Re: [git patches] net driver updates for .26

From: Jeff Garzik <jeff@...zik.org>
Date: Tue, 18 Mar 2008 03:59:02 -0400

> 
> Just sent this upstream to davem for 2.6.26...  snipped the patch I
> usually post along with a git push, due to mailing list restrictions.
> 
> Please pull from 'upstream-net26' branch of
> master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git upstream-net26

This fails an allmodconfig build:

drivers/net/8390.c: In function '__inittest':
drivers/net/8390.c:60: error: 'ns8390_init_module' undeclared (first use in this function)
drivers/net/8390.c:60: error: (Each undeclared identifier is reported only once
drivers/net/8390.c:60: error: for each function it appears in.)

The fix was easy so I took care of it, this time...

There was also a merge conflict in drivers/s390/net/qeth_main.c
(against a net-2.6.26 change, which is why you really should work
against that for 2.6.26 bound changes not against Linus's head as you
did here), which is easy to resolve by putting the conflicting change
to qeth_main.c into the inetdev notifier in qeth_l3_main.c, which
I took care of as well.

This time....

There are also some new build warnings such as:

drivers/net/atlx/atl1.c:506: warning: 'atl1_phy_enter_power_saving' defined but not used

Which I fixed up as well, but that atl1_phy_enter_power_saving()
function is just a jumble of commented out code, yuck!  Please
review some of this stuff :-/

I'm not doing all of these fixups next time just to make your
tree pullable, ok?

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html