netdev - Re: [PATCH 4/8] New driver "sfc" for Solarstorm SFC4000 controller (try #8)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080323.223736.169461798.davem@davemloft.net>
Date:	Sun, 23 Mar 2008 22:37:36 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	bhutchings@...arflare.com
Cc:	netdev@...r.kernel.org, linux-net-drivers@...arflare.com,
	jgarzik@...ox.com
Subject: Re: [PATCH 4/8] New driver "sfc" for Solarstorm SFC4000 controller
 (try #8)

From: Ben Hutchings <bhutchings@...arflare.com>
Date: Wed, 12 Mar 2008 01:24:39 +0000

> +static void falcon_setup_rss_indir_table(struct efx_nic *efx)
> +{
> +	int i = 0;
> +	unsigned long offset;
> +	unsigned long flags __attribute__ ((unused));
> +	efx_dword_t dword;

Please delete this unused variable.

> +static int falcon_mdio_read(struct net_device *net_dev, int phy_id, int addr)
> +{
> +	struct efx_nic *efx = (struct efx_nic *)net_dev->priv;
> +	unsigned int phy_addr = phy_id & FALCON_PHY_ID_ID_MASK;
> +	efx_oword_t reg;
> +	int value = -1;
> +	unsigned long flags __attribute__ ((unused));

This one too.

Otherwise mostly looks fine.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html