netdev - Re: [PATCH 8/8] New driver "sfc" for Solarstorm SFC4000 controller (try #8)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 24 Mar 2008 10:34:40 +0000
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Christoph Hellwig <hch@...radead.org>
Cc:	netdev@...r.kernel.org, linux-net-drivers@...arflare.com,
	Jeff Garzik <jgarzik@...ox.com>,
	David Miller <davem@...emloft.net>
Subject: Re: [PATCH 8/8] New driver "sfc" for Solarstorm SFC4000 controller (try #8)

Christoph Hellwig wrote:
> > +++ b/drivers/net/sfc/Makefile
> > @@ -0,0 +1,23 @@
> > +
> > +# Final objects
> > +sfc_o = sfc.o
> > +
> > +# Constituent objects
> > +sfc_elements_o :=
> > +sfc_elements_o += efx.o
> > +sfc_elements_o += falcon.o
> > +sfc_elements_o += tx.o
> > +sfc_elements_o += rx.o
> > +sfc_elements_o += falcon_xmac.o
> > +sfc_elements_o += i2c-direct.o
> > +sfc_elements_o += ethtool.o
> > +sfc_elements_o += xfp_phy.o
> > +sfc_elements_o += mdio_10g.o
> > +sfc_elements_o += tenxpress.o
> > +sfc_elements_o += boards.o
> > +sfc_elements_o += sfe4001.o
> > +
> > +obj-$(CONFIG_SFC) += $(sfc_o)
> > +
> > +sfc-objs = $(sfc_elements_o)
> 
> Very strange makefile.  This should be:
> 
> sfc-y			+= efx.o falcon.o tx.o rx.o falcon_xmac.o \					   i2c-direct.o ethtool.o xfp_phy.o mdio_10g.o \
> 			   tenxpress.o boards.o sfe4001.o
> 
> obj-$(CONFIG_SFC)	+= sfc.o

The Makefile and all the source files are derived from an internal
version, processed to remove code that's not suitable for upstream.
But they're not strictly tracking that version any more, so we could
just write it the simple way.

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html