lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 23 Mar 2008 14:59:40 +0100 From: Pavel Machek <pavel@....cz> To: Harvey Harrison <harvey.harrison@...il.com> Cc: Al Viro <viro@...IV.linux.org.uk>, Andrew Morton <akpm@...ux-foundation.org>, LKML <linux-kernel@...r.kernel.org>, linux-netdev <netdev@...r.kernel.org> Subject: Re: [RFC PATCH] kernel: add byteorder macros with alignment fixups On Thu 2008-03-20 12:22:33, Harvey Harrison wrote: > Create linux/unaligned.h to hold a common pattern in the kernel: > > le32_to_cpu(get_unaligned((__le32 *)x)); > > Repeat for various combinations of le/be and 64/32/16 bit. Add > a variant that operates on possibly unaligned pointers to > byteorder/generic.h > > Signed-off-by: Harvey Harrison <harvey.harrison@...il.com> > --- > Now the indirect include of asm/unaligned is opt-in when places > add the linux/unaligned header. > > include/linux/unaligned.h | 42 ++++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 42 insertions(+), 0 deletions(-) > > diff --git a/include/linux/unaligned.h b/include/linux/unaligned.h > new file mode 100644 > index 0000000..7d8fddc > --- /dev/null > +++ b/include/linux/unaligned.h > @@ -0,0 +1,42 @@ > +#ifndef _LINUX_UNALIGNED_H_ > +#define _LINUX_UNALIGNED_H_ > + > +#include <linux/types.h> > +#include <asm/byteorder.h> > +#include <asm/unaligned.h> > + > +#ifdef __KERNEL__ > + > +static inline u64 le64_to_cpu_unaligned(void *p) > +{ > + return __le64_to_cpu(get_unaligned((__le64 *)p)); > +} Why the cast? Should le64_to_cpu() take __le64 * parameter, so that normal typechecking still works? Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists