netdev - Re: [PATCH 2/3] [LLC]: bogus llc packet length

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080324164310.GD32612@ghostprotocols.net>
Date:	Mon, 24 Mar 2008 13:43:10 -0300
From:	Arnaldo Carvalho de Melo <acme@...hat.com>
To:	joonwpark81@...il.com
Cc:	davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH 2/3] [LLC]: bogus llc packet length

Em Mon, Mar 24, 2008 at 05:34:16PM +0900, joonwpark81@...il.com escreveu:
> From: Joonwoo Park <joonwpark81@...il.com>
> 
> discard llc packet which has bogus packet length.
> 
> Signed-off-by: Joonwoo Park <joonwpark81@...il.com>
> ---
> diff --git a/net/llc/llc_input.c b/net/llc/llc_input.c
> index c40c9b2..a2bbc7c 100644
> --- a/net/llc/llc_input.c
> +++ b/net/llc/llc_input.c
> @@ -117,8 +117,12 @@ static inline int llc_fixup_skb(struct sk_buff *skb)
>  	skb_pull(skb, llc_len);
>  	if (skb->protocol == htons(ETH_P_802_2)) {
>  		__be16 pdulen = eth_hdr(skb)->h_proto;
> -		u16 data_size = ntohs(pdulen) - llc_len;
> +		s32 data_size = ntohs(pdulen) - llc_len;
>  
> +		if (data_size < 0
> +		    || ((skb_tail_pointer(skb) - (u8 *)pdu) - llc_len)
> +			< data_size)
> +			return 0;

Rewrite this as:

		if (data_size < 0 ||
		    ((skb_tail_pointer(skb) -
		      (u8 *)pdu) - llc_len) < data_size)

And stick my:

Acked-by: Arnaldo Carvalho de Melo <acme@...hat.com>

:-)

>  		if (unlikely(pskb_trim_rcsum(skb, data_size)))
>  			return 0;
>  	}
> -- 
> 1.5.4.3
> 
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html