netdev - Re: [PATCH] ehea: Fix IPv6 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <47E91D10.5060607@de.ibm.com>
Date:	Tue, 25 Mar 2008 16:41:04 +0100
From:	Thomas Klein <osstklei@...ibm.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
CC:	jeff@...zik.org, raisch@...ibm.com, themann@...ibm.com,
	linux-kernel@...r.kernel.org, linuxppc-dev@...abs.org,
	netdev@...r.kernel.org, stefan.roscher@...ibm.com,
	hering2@...ibm.com, stable@...nel.org
Subject: Re: [PATCH] ehea: Fix IPv6 support

Andrew Morton wrote:
> On Wed, 19 Mar 2008 13:55:43 +0100
> Thomas Klein <osstklei@...ibm.com> wrote:
> 
>> Indicate that HEA calculates IPv4 checksums only
>>
>> Signed-off-by: Thomas Klein <tklein@...ibm.com>
>>
>> ---
>> diff -Nurp -X dontdiff linux-2.6.25-rc6/drivers/net/ehea/ehea.h patched_kernel/drivers/net/ehea/ehea.h
>> --- linux-2.6.25-rc6/drivers/net/ehea/ehea.h	2008-03-17 00:32:14.000000000 +0100
>> +++ patched_kernel/drivers/net/ehea/ehea.h	2008-03-19 08:58:07.000000000 +0100
>> @@ -40,7 +40,7 @@
>>  #include <asm/io.h>
>>  
>>  #define DRV_NAME	"ehea"
>> -#define DRV_VERSION	"EHEA_0087"
>> +#define DRV_VERSION	"EHEA_0089"
>>  
>>  /* eHEA capability flags */
>>  #define DLPAR_PORT_ADD_REM 1
>> diff -Nurp -X dontdiff linux-2.6.25-rc6/drivers/net/ehea/ehea_main.c patched_kernel/drivers/net/ehea/ehea_main.c
>> --- linux-2.6.25-rc6/drivers/net/ehea/ehea_main.c	2008-03-17 00:32:14.000000000 +0100
>> +++ patched_kernel/drivers/net/ehea/ehea_main.c	2008-03-19 08:58:07.000000000 +0100
>> @@ -3108,7 +3108,7 @@ struct ehea_port *ehea_setup_single_port
>>  	dev->vlan_rx_add_vid = ehea_vlan_rx_add_vid;
>>  	dev->vlan_rx_kill_vid = ehea_vlan_rx_kill_vid;
>>  	dev->features = NETIF_F_SG | NETIF_F_FRAGLIST | NETIF_F_TSO
>> -		      | NETIF_F_HIGHDMA | NETIF_F_HW_CSUM | NETIF_F_HW_VLAN_TX
>> +		      | NETIF_F_HIGHDMA | NETIF_F_IP_CSUM | NETIF_F_HW_VLAN_TX
>>  		      | NETIF_F_HW_VLAN_RX | NETIF_F_HW_VLAN_FILTER
>>  		      | NETIF_F_LLTX;
>>  	dev->tx_timeout = &ehea_tx_watchdog;
> 
> That looks like a pretty significant fix to me?  Should it be backported to
> 2.6.24.x?

Agreed. I'll send a patch.

Thomas
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html