netdev - Re: [RFC PATCH net-2.6.26 2/3] [NET] NETNS: Omit sock->sk_net without CONFIG_NET

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <47E948E2.6020800@hp.com>
Date:	Tue, 25 Mar 2008 14:48:02 -0400
From:	Brian Haley <brian.haley@...com>
To:	YOSHIFUJI Hideaki / ???? 
	<yoshfuji@...ux-ipv6.org>
Cc:	davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [RFC PATCH net-2.6.26 2/3] [NET] NETNS: Omit sock->sk_net without
 CONFIG_NET_NS.

YOSHIFUJI Hideaki / ???? wrote:
> Introduce per-sock inlines: sock_net(), sock_net_set().
> Without CONFIG_NET_NS, no namespace other than &init_net exists.
> Let's explicitly define them to help compiler optimizations.

> diff --git a/include/net/sock.h b/include/net/sock.h
> index b433b1e..7e0d4a0 100644
> --- a/include/net/sock.h
> +++ b/include/net/sock.h
> @@ -126,7 +126,9 @@ struct sock_common {
>  	atomic_t		skc_refcnt;
>  	unsigned int		skc_hash;
>  	struct proto		*skc_prot;
> +#ifdef CONFIG_NET_NS
>  	struct net	 	*skc_net;
> +#endif
>  };

net/ipv4/inet_timewait_sock.c: In function ‘inet_twsk_alloc’:
net/ipv4/inet_timewait_sock.c:127: error: ‘struct sock_common’ has no 
member named ‘skc_net’

Maybe this was the issue you already found yourself, patch below.

-Brian


Signed-off-by: Brian Haley <brian.haley@...com>

View attachment "skc_net_ns.patch" of type "text/x-patch" (2851 bytes)