netdev - [PATCH stable] b44: Truncate PHY address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <200803261500.08699.mb@bu3sch.de>
Date:	Wed, 26 Mar 2008 15:00:08 +0100
From:	Michael Buesch <mb@...sch.de>
To:	stable@...nel.org
Cc:	Jeff Garzik <jeff@...zik.org>, agb@...nwrt.org,
	Gary Zambrano <zambrano@...adcom.com>, netdev@...r.kernel.org
Subject: [PATCH stable] b44: Truncate PHY address

Some ROMs on embedded devices store incorrect values for
the PHY address of the ethernet device.
It looks like the number is sign-extended.
Truncate the value by applying the PHY-address mask to it.
The patch was tested on a bcm47xx embedded system (where the bug
triggers) and a bcm4400 PCI card.

Signed-off-by: Michael Buesch <mb@...sch.de>

---

This patch is applied to the netdev tree.
Commit is 5ea79631c0c47d28831a0635e8af9da539d449cd


Index: linux-2.6.24.3/drivers/net/b44.c
===================================================================
--- linux-2.6.24.3.orig/drivers/net/b44.c	2008-01-24 23:58:37.000000000 +0100
+++ linux-2.6.24.3/drivers/net/b44.c	2008-03-26 14:54:13.000000000 +0100
@@ -2066,6 +2066,11 @@ static int __devinit b44_get_invariants(
 		addr = sdev->bus->sprom.r1.et0mac;
 		bp->phy_addr = sdev->bus->sprom.r1.et0phyaddr;
 	}
+	/* Some ROMs have buggy PHY addresses with the high
+	 * bits set (sign extension?). Truncate them to a
+	 * valid PHY address. */
+	bp->phy_addr &= 0x1F;
+
 	memcpy(bp->dev->dev_addr, addr, 6);
 
 	if (!is_valid_ether_addr(&bp->dev->dev_addr[0])){


-- 
Greetings Michael.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html