netdev - Re: [PATCH] Improvev netconsole support for RTL8139 NIC driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <47E9BA6C.2010502@windriver.com>
Date:	Wed, 26 Mar 2008 10:52:28 +0800
From:	yshi <yang.shi@...driver.com>
To:	David Miller <davem@...emloft.net>
CC:	jgarzik@...ox.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Improvev netconsole support for RTL8139 NIC driver

David Miller 写道:
> From: Jeff Garzik <jgarzik@...ox.com>
> Date: Tue, 25 Mar 2008 22:23:24 -0400
>
>   
>> This is bogus -- you should never need to slow down the hot path in such 
>> a way.
>>     
>
> Slow down in what way?  Even on x86 saving the flags is just
> about as expensive as a plain sti/cli.
>
> I would in fact prefer to see drivers unconditionally use
> spin_lock_irqsave() et al. in the interrupt handler, for
> consistency.
>   
Yes, I agree. Many NIC drivers do the same thing, like Gianfar, E1000, etc.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html