| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <47EA9911.8040101@garzik.org> Date: Wed, 26 Mar 2008 14:42:25 -0400 From: Jeff Garzik <jeff@...zik.org> To: Auke Kok <auke-jan.h.kok@...el.com> CC: netdev@...r.kernel.org, e1000-devel@...ts.sourceforge.net Subject: Re: [PATCH] e1000e: test MSI interrupts Auke Kok wrote: > From: Jesse Brandeburg <jesse.brandeburg@...el.com> > > Test the MSI interrupt physically once before assuming that it > actually works. Several platforms have already come across that > have non-functional MSI interrupts and this code will attempt > to detect those safely. Once the test succeeds MSI interrupts > will be enabled. > > Signed-off-by: Jesse Brandeburg <jesse.brandeburg@...el.com> > Signed-off-by: Auke Kok <auke-jan.h.kok@...el.com> > --- > > drivers/net/e1000e/defines.h | 1 > drivers/net/e1000e/e1000.h | 1 > drivers/net/e1000e/netdev.c | 161 ++++++++++++++++++++++++++++++++++++++++-- > 3 files changed, 155 insertions(+), 8 deletions(-) Ah, the perennial add-same-test-to-every-driver conundrum. I think we are far enough along with MSI to _not_ do this anymore in drivers. The platforms with MSI problems should be discovered, made public, and worked around. Otherwise you hide the same problem, just for someone else to discover with another component of the machine. Jeff -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists