[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20080326.165002.128017657.davem@davemloft.net>
Date: Wed, 26 Mar 2008 16:50:02 -0700 (PDT)
From: David Miller <davem@...emloft.net>
To: dlezcano@...ibm.com
Cc: xemul@...nvz.org, netdev@...r.kernel.org, devel@...nvz.org
Subject: Re: [PATCH net-2.6.26][IPV6]: Fix potential net leak and oops in
ipv6 routing code.
From: Daniel Lezcano <dlezcano@...ibm.com>
Date: Wed, 26 Mar 2008 16:59:29 +0100
> Pavel Emelyanov wrote:
> > The commits f3db4851 ([NETNS][IPV6] ip6_fib - fib6_clean_all handle several
> > network namespaces) and 69ddb805 ([NETNS][IPV6] route6 - Make proc entry
> > /proc/net/rt6_stats per namespace) made some proc files per net.
> >
> > Both of them introduced potential OOPS - get_proc_net can return NULL, but
> > this check is lost - and a struct net leak - in case single_open() fails the
> > previously got net is not put.
> >
> > Kill all these bugs with one patch.
> >
> > Signed-off-by: Pavel Emelyanov <xemul@...nvz.org>
...
> Good catch. Thanks.
>
> Acked-by: Daniel Lezcano <dlezcano@...ibm.com>
Applied, thanks everyone!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists