netdev - Re: [PATCH] Add support the Korina (IDT RC32434) Ethernet MAC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <47E9D2C3.7050006@garzik.org>
Date:	Wed, 26 Mar 2008 00:36:19 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Florian Fainelli <florian.fainelli@...ecomint.eu>
CC:	Francois Romieu <romieu@...zoreil.com>,
	Johannes Berg <johannes@...solutions.net>,
	David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
	Felix Fietkau <nbd@...nwrt.org>
Subject: Re: [PATCH] Add support the Korina (IDT RC32434) Ethernet MAC

Florian Fainelli wrote:
> Hi Francois,
> 
> Le lundi 17 mars 2008, Francois Romieu a écrit :
>>> Thanks for your comments, here is a third try which adresses the
>>> mentionned problems.
> 
> It is allright, thanks for your concise answers. 1-2,4-15 should be fixed now.
> 
>> 3. korina_rx() still drops the received skb each time dev_alloc_skb fails.
>>    This is far from optimal.
> 
> I now simply break into the while loop, which should allow more luck for failed allocation descriptors on next round. Seems like other 
> 
> Also, I fixed the multicast handling which was not done for filtered multicast traffic.
> 
> Below is the fourth try of the driver.
> --
> From: Florian Fainelli <florian.fainelli@...ecomint.eu>
> Subject: [PATCH] Add support the Korina (IDT RC32434) Ethernet MAC
> 
> This patch adds support for the IDT rc32434 Ethernet MAC
> we can find in the IDT boards and the Mikrotik RB500.
> Driver references some code from the linux-mips RB500
> support.
> 
> Signed-off-by: Florian Fainelli <florian.fainelli@...ecomint.eu>
> Signed-off-by: Felix Fietkau <nbd@...nwrt.org>
> Signed-off-by: Philip Rischel <rischelp@....com>

I applied this version...  please send changes after this as separate 
patches


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html