netdev - Re: [PATCH] [NET] phy/broadcom: add support for BCM5481 PHY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <47E9D2D9.3030900@pobox.com>
Date:	Wed, 26 Mar 2008 00:36:41 -0400
From:	Jeff Garzik <jgarzik@...ox.com>
To:	avorontsov@...mvista.com
CC:	"Maciej W. Rozycki" <macro@...ux-mips.org>,
	Andy Fleming <afleming@...escale.com>, netdev@...r.kernel.org
Subject: Re: [PATCH] [NET] phy/broadcom: add support for BCM5481 PHY

Anton Vorontsov wrote:
> On Wed, Feb 06, 2008 at 06:44:32AM -0500, Jeff Garzik wrote:
>> Anton Vorontsov wrote:
>>> This patch adds support for BCM5481 PHY. Unfortunately it's hard to
>>> get specifications for this PHY, so its special register 0x18 isn't
>>> annotated properly (but we know it's used to set up the delays).
>>>
>>> I've kept the magic numbers, so we'll not forget to fix it at the
>>> first opportunity, and will name that register and its bits correctly.
>>>
>>> Signed-off-by: Anton Vorontsov <avorontsov@...mvista.com>
> [...]
>>> +static struct phy_driver bcm5481_driver = {
>>> +	.phy_id		= 0x0143bca0,
>>> +	.phy_id_mask	= 0xfffffff0,
> [...]
>> applied
> 
> :-) You applied "PHYLIB: Add BCM5482 PHY support", but my
> patch is for another PHY -- BCM5481. Here is another try,
> rebased on top of previous commit:
> 
> - - - -
> From: Anton Vorontsov <avorontsov@...mvista.com>
> Subject: phylib, broadcom: add support for BCM5481 PHY
> 
> This patch adds support for BCM5481 PHY. Unfortunately it's hard to
> get specifications for this PHY, so its special register 0x18 isn't
> annotated properly (but we know it's used to set up the delays).
> 
> I've kept the magic numbers, so we'll not forget to fix it at the
> first opportunity, and will name that register and its bits correctly.
> 
> p.s. also fixed the line with broken indention, introduced by
> commit 03157ac31eb4a8883382a212b161d2e6c5059fbf
>     PHYLIB: Add BCM5482 PHY support
> 
> Signed-off-by: Anton Vorontsov <avorontsov@...mvista.com>
> ---
>  drivers/net/phy/broadcom.c |   57 +++++++++++++++++++++++++++++++++++++++++++-
>  1 files changed, 56 insertions(+), 1 deletions(-)

applied


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html