netdev - Re: [PATCH 2 of 5] IPv6: only update the lifetime of the relevant temporary address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080328.033144.21651958.yoshfuji@linux-ipv6.org>
Date:	Fri, 28 Mar 2008 03:31:44 +0900 (JST)
From:	YOSHIFUJI Hideaki / 吉藤英明 
	<yoshfuji@...ux-ipv6.org>
To:	benoit.boissinot@...-lyon.org
Cc:	netdev@...r.kernel.org, pekkas@...core.fi, yoshfuji@...ux-ipv6.org
Subject: Re: [PATCH 2 of 5] IPv6: only update the lifetime of the relevant
 temporary address

In article <5e50b19fbb757f080905.1206305170@...zuine> (at Sun, 23 Mar 2008 21:46:10 +0100), Benoit Boissinot <benoit.boissinot@...-lyon.org> says:

> IPv6: only update the lifetime of the relevant temporary address
> 
> When receiving a prefix information from a routeur, only update the lifetimes
> of the temporary address associated with that prefix.
> Otherwise if one deprecated prefix is advertized, all your temporary addresses
> will become deprecated.
> 
> Signed-off-by: Benoit Boissinot <benoit.boissinot@...-lyon.org>

I generally agree.

> diff -r dd125a7f8696 -r 5e50b19fbb75 net/ipv6/addrconf.c
> --- a/net/ipv6/addrconf.c	Sat Mar 22 00:50:21 2008 +0100
> +++ b/net/ipv6/addrconf.c	Sat Mar 22 00:41:39 2008 +0100
> @@ -1832,6 +1832,10 @@
>  				 * when processing a Prefix Information Option.
>  				 */
>  				spin_lock(&ift->lock);
> +				if (ifp != ift->ifpub) {
> +					spin_unlock(&ift->lock);
> +					continue;
> +				}
>  				flags = ift->flags;
>  				if (ift->valid_lft > valid_lft &&
>  				    ift->valid_lft - valid_lft > (jiffies - ift->tstamp) / HZ)

I think you can compare ift->ifpub outside the lock here.

--yoshfuji
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html