netdev - Re: [patch for 2.6.25? 1/1] bonding: fix sysfs attribute handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <47EB9188.5080500@garzik.org>
Date:	Thu, 27 Mar 2008 08:22:32 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	akpm@...ux-foundation.org
CC:	davem@...emloft.net, netdev@...r.kernel.org, lpechacek@...e.cz,
	fubar@...ibm.com, stable@...nel.org
Subject: Re: [patch for 2.6.25? 1/1] bonding: fix sysfs attribute handling

akpm@...ux-foundation.org wrote:
> From: Libor Pechacek <lpechacek@...e.cz>
> 
> For bonding interfaces any attempt to read the sysfs directory contents after
> module removal results in an oops.  The fix is to release sysfs attributes for
> the interfaces upon module unload.
> 
> Signed-off-by: Libor Pechacek <lpechacek@...e.cz>
> Acked-by: Jay Vosburgh <fubar@...ibm.com>
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: <stable@...nel.org>
> Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>
> ---
> 
>  drivers/net/bonding/bond_main.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff -puN drivers/net/bonding/bond_main.c~bonding-fix-sysfs-attribute-handling drivers/net/bonding/bond_main.c
> --- a/drivers/net/bonding/bond_main.c~bonding-fix-sysfs-attribute-handling
> +++ a/drivers/net/bonding/bond_main.c
> @@ -4528,8 +4528,7 @@ static void bond_free_all(void)
>  		netif_tx_unlock_bh(bond_dev);
>  		/* Release the bonded slaves */
>  		bond_release_all(bond_dev);
> -		bond_deinit(bond_dev);
> -		unregister_netdevice(bond_dev);
> +		bond_destroy(bond);

sent upstream already (davem has it in net-2.6, bound for upstream)


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html