netdev - Re: [PATCH 7/11 net-2.6.26] [ICMP]: Simplify ICMP control socket creation.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080328144726.GV14945@ghostprotocols.net>
Date:	Fri, 28 Mar 2008 11:47:26 -0300
From:	Arnaldo Carvalho de Melo <acme@...hat.com>
To:	"Denis V. Lunev" <den@...nvz.org>
Cc:	davem@...emloft.net, netdev@...r.kernel.org,
	containers@...ts.osdl.org
Subject: Re: [PATCH 7/11 net-2.6.26] [ICMP]: Simplify ICMP control socket
	creation.

Em Fri, Mar 28, 2008 at 12:08:54PM +0300, Denis V. Lunev escreveu:
> Replace sock_create_kern with inet_csk_ctl_sock_create.
> 
> Signed-off-by: Denis V. Lunev <den@...nvz.org>
> ---
>  net/ipv4/icmp.c |   23 +++++------------------
>  1 files changed, 5 insertions(+), 18 deletions(-)
> 
> diff --git a/net/ipv4/icmp.c b/net/ipv4/icmp.c
> index 803bc9f..b00bc20 100644
> --- a/net/ipv4/icmp.c
> +++ b/net/ipv4/icmp.c
> @@ -1152,33 +1152,20 @@ int __net_init icmp_sk_init(struct net *net)
>  
>  	for_each_possible_cpu(i) {
>  		struct sock *sk;
> -		struct socket *sock;
> -		struct inet_sock *inet;
>  
> -		err = sock_create_kern(PF_INET, SOCK_RAW, IPPROTO_ICMP, &sock);
> +		err = inet_csk_ctl_sock_create(&sk,
> +					       PF_INET, SOCK_RAW, IPPROTO_ICMP);

And ICMP surely is not a inet_connection_sock, so please rename it as
suggested in another message.

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html