netdev - Bug in cs89x0.c?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Date:	Fri, 28 Mar 2008 16:09:06 +0100 (CET)
From:	Guennadi Liakhovetski <lg@...x.de>
To:	netdev@...r.kernel.org
Subject: Bug in cs89x0.c?

Hi

Do I understand it right, that this

705:		i = readreg(dev, PP_LineCTL);
706:		/* Preserve the setting of the HCB1 pin. */
707:		if ((i & (HCB1 | HCB1_ENBL)) ==  (HCB1 | HCB1_ENBL))
708:			lp->adapter_cnf |= A_CNF_DC_DC_POLARITY;

(line numbers may deviate slightly) is a bug? HCB1 and HCB1_ENBL bits are 
from the PP_SelfCTL and not from the PP_LineCTL register...

Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office@...x.de
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html